Zivid 8878 support nested data model types #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeName returns the name of the Python type that represents a data model node. For a nested datamodel this is the wrapped class of the nested datamodel.
Nested datamodels are stored within the datamodel frontend as instances of the frontend of the nested datamodel model.
vawale
approved these changes
Nov 28, 2024
|
|
||
| std::array<char, prefixLength + nameLength + 1> result{ '\0' }; | ||
|
|
||
| // TODO: Switch to std::copy_n when we can switch to C++20 and drop support for GCC 9. |
There was a problem hiding this comment.
nitpick: maybe mention that std::copy is not used because it is not constexpr before C++20?
| datamodel_name = child.underlying_zivid_class.value_type.split(".")[-1] | ||
| datamodel_name_snake = _to_snake_case(datamodel_name) | ||
| child.is_nested_datamodel = True | ||
| datamodel_snake_case = _to_snake_case(datamodel_name) |
There was a problem hiding this comment.
datamodel_name_snake and datamodel_snake_case are the same thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the datamodel wrapper and frontend generator to support nested datamodels.
It won't build yet due to lacking
IsDataModelRoottrait