Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ase md failing for bad models #355

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix ase md failing for bad models #355

merged 3 commits into from
Dec 3, 2024

Conversation

M-R-Schaefer
Copy link
Contributor

if a simulation fails immediately due to a check, the node would fail as the steps list in the metrics dict is empty

PythonFZ
PythonFZ approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@PythonFZ PythonFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this even a thing. Wasn't step missing from the function from the beginning?

@M-R-Schaefer
Copy link
Contributor Author

How was this even a thing. Wasn't step missing from the function from the beginning?

yes, no idea how it worked

@M-R-Schaefer M-R-Schaefer enabled auto-merge (squash) December 3, 2024 11:08
@M-R-Schaefer M-R-Schaefer merged commit be97528 into main Dec 3, 2024
2 of 4 checks passed
@M-R-Schaefer M-R-Schaefer deleted the fix_ase branch December 3, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PythonFZ PythonFZ PythonFZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-R-Schaefer @PythonFZ