Add migration to addon_config #649
Merged
+59
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Koenkk
pushed a commit
that referenced
this pull request
Dec 1, 2024
* mount addon_config into container * add addon_config migration
Nerivec
reviewed
Dec 2, 2024
| export ZIGBEE2MQTT_DATA="$(bashio::config 'data_path')" | ||
|
|
||
| # Migrate configuration to addon specific data path for HA backups, see https://github.com/zigbee2mqtt/hassio-zigbee2mqtt/issues/627 | ||
| if [[ "$ZIGBEE2MQTT_DATA" == "/addon_config/zigbee2mqtt" ]] && ! bashio::fs.file_exists "$ZIGBEE2MQTT_DATA/configuration.yaml" && bashio::fs.file_exists "/config/zigbee2mqtt/configuration.yaml"; then |
There was a problem hiding this comment.
Looks like the folder is named addon_configs not addon_config?
(same for other refs in PR, and #642)
There was a problem hiding this comment.
The config folder is mounted to /addon_config/ as specified in the config.json
avbor
pushed a commit
to avbor-z2m/hassio-zigbee2mqtt-1
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
avbor
pushed a commit
to avbor-z2m/hassio-zigbee2mqtt-2
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
avbor
pushed a commit
to avbor-z2m/hassio-zigbee2mqtt-3
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
avbor
pushed a commit
to avbor-z2m/hassio-zigbee2mqtt-4
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
benjamin-dcs
pushed a commit
to multi-z2m-1/hassio-zigbee2mqtt
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
benjamin-dcs
pushed a commit
to multi-z2m-2/hassio-zigbee2mqtt
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
benjamin-dcs
pushed a commit
to multi-z2m-3/hassio-zigbee2mqtt
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
benjamin-dcs
pushed a commit
to multi-z2m-4/hassio-zigbee2mqtt
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
benjamin-dcs
pushed a commit
to multi-z2m-6/hassio-zigbee2mqtt
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
benjamin-dcs
pushed a commit
to multi-z2m-7/hassio-zigbee2mqtt
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
benjamin-dcs
pushed a commit
to multi-z2m-8/hassio-zigbee2mqtt
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
benjamin-dcs
pushed a commit
to multi-z2m-9/hassio-zigbee2mqtt
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
benjamin-dcs
pushed a commit
to multi-z2m-10/hassio-zigbee2mqtt
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
benjamin-dcs
pushed a commit
to multi-z2m-5/hassio-zigbee2mqtt
that referenced
this pull request
Dec 3, 2024
* mount addon_config into container * add addon_config migration
|
@BigBoot yes something really weird happend. It's almost as if the addon was picking the config.json from the branch. I reverted it by removing the changes from the master branch, parked the changes in https://github.com/zigbee2mqtt/hassio-zigbee2mqtt/commits/2.0.0/ |
|
As explained on the HA docs, the https://developers.home-assistant.io/docs/add-ons/configuration/ 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #642 intended for 2.0.0