Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add StartWithListener method to api and rpc server #4465

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

winteriscome
Copy link

@winteriscome winteriscome commented Nov 22, 2024

add StartWithListener method to api and rpc

more friendly support third-party packages to implement graceful upgrades
such as

fvbock/endless
jpillora/overseer
cloudflare/tableflip

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 66.25000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 94.42%. Comparing base (8690859) to head (7b24a25).
Report is 166 commits behind head on master.

Files with missing lines Patch % Lines
rest/engine.go 25.00% 12 Missing ⚠️
rest/internal/starter.go 61.29% 10 Missing and 2 partials ⚠️
zrpc/server.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
rest/server.go 96.90% <100.00%> (+0.37%) ⬆️
zrpc/internal/rpcserver.go 100.00% <100.00%> (ø)
zrpc/internal/server.go 100.00% <ø> (ø)
zrpc/server.go 86.11% <25.00%> (+1.30%) ⬆️
rest/engine.go 95.14% <25.00%> (-4.86%) ⬇️
rest/internal/starter.go 67.74% <61.29%> (-6.46%) ⬇️

... and 5 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants