2024.3 support - add com.intellij.modules.json dependency #456
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
asaarilahti
force-pushed
the
add-json-dependency
branch
from
39a50c4
to
e188920
Compare
asaarilahti
force-pushed
the
add-json-dependency
branch
from
e188920
to
03a314c
Compare
| <depends>com.intellij.modules.lang</depends> | ||
| <depends>com.intellij.modules.json</depends> <!-- Bundled plugin starting from 2024.3 --> |
There was a problem hiding this comment.
So if the previous versions of IntellIj don't have this, will it still work with older versions?
There was a problem hiding this comment.
As far as I understand, it has been a module and in 2024.3 it was migrated to a (bundled) plugin. So, older versions have it and the declaration for the dependency was just missing.
However, it's not clear if this will be enough, or if we need to also add a plugin dependency. The challenge there is that the json plugin is only available for 2024.3.
There was a problem hiding this comment.
Thanks for explanation. But how would we then find out? Just merging this PR and see what happens?
There was a problem hiding this comment.
Generally yes. We can do a release to the beta channel.
There was a problem hiding this comment.
So what is then preventing us to move this PR from draft to ready for review?
#455
PluginVerifier does not flag the issue, so unclear if this is enough. If it isn't, the plugin needs to be added to the plugins list in build.gradle.kts. This means that either the minimum supported Idea version needs to be bumped to 2024.3 or that multiple versions targeting different Idea versions need to be published.