Skip to content

Commit

Permalink
Revert of Expose IA and IA2 role and state for HTML input type attrib…
Browse files Browse the repository at this point in the history
…utes related to date and time. (patchset #1 id:1 of https://codereview.chromium.org/612063002/)

Reason for revert:
This likely broke DumpAccessibilityTreeTest.AccessibilityInputTime in
content_browsertest

Original issue's description:
> Expose IA and IA2 role and state for HTML input type attributes related to date and time.
> 
> For input type date, datetime and datetime-local, time, month, week - IA and IA2 role and states
> are not exposed properly.
> 
> BUG=418486
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182848

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=418486

Review URL: https://codereview.chromium.org/609403005

git-svn-id: svn://svn.chromium.org/blink/trunk@182863 bbb929c8-8fbe-4397-9dbb-9b2b20218538
  • Loading branch information
zhenyao committed Sep 29, 2014
1 parent f3f5b34 commit 0c6b223
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 27 deletions.
9 changes: 0 additions & 9 deletions Source/core/accessibility/AXNodeObject.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -212,13 +212,6 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()
return CheckBoxMenuItemRole;
return CheckBoxRole;
}
if (type == InputTypeNames::date)
return DateRole;
if (type == InputTypeNames::datetime
|| type == InputTypeNames::datetime_local
|| type == InputTypeNames::month
|| type == InputTypeNames::week)
return DateTimeRole;
if (type == InputTypeNames::radio)
return RadioButtonRole;
if (input.isTextButton())
Expand All @@ -227,8 +220,6 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()
return SliderRole;
if (type == InputTypeNames::color)
return ColorWellRole;
if (type == InputTypeNames::time)
return TimeRole;
return TextFieldRole;
}
if (isHTMLSelectElement(*node())) {
Expand Down
3 changes: 0 additions & 3 deletions Source/core/accessibility/AXObject.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ enum AccessibilityRole {
ComboBoxRole,
ComplementaryRole,
ContentInfoRole,
DateRole,
DateTimeRole,
DefinitionRole,
DescriptionListDetailRole,
DescriptionListTermRole,
Expand Down Expand Up @@ -168,7 +166,6 @@ enum AccessibilityRole {
TableRole,
TextAreaRole,
TextFieldRole,
TimeRole,
TimerRole,
ToggleButtonRole,
ToolbarRole,
Expand Down
9 changes: 0 additions & 9 deletions Source/core/accessibility/AXRenderObject.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -323,21 +323,12 @@ AccessibilityRole AXRenderObject::determineAccessibilityRole()
return CheckBoxMenuItemRole;
return CheckBoxRole;
}
if (type == InputTypeNames::date)
return DateRole;
if (type == InputTypeNames::datetime
|| type == InputTypeNames::datetime_local
|| type == InputTypeNames::month
|| type == InputTypeNames::week)
return DateTimeRole;
if (type == InputTypeNames::radio)
return RadioButtonRole;
if (input.isTextButton())
return buttonRoleType();
if (type == InputTypeNames::color)
return ColorWellRole;
if (type == InputTypeNames::time)
return TimeRole;
}

if (isFileUploadButton())
Expand Down
3 changes: 0 additions & 3 deletions Source/web/AssertMatchingEnums.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,6 @@ COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleColumn, ColumnRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleComboBox, ComboBoxRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleComplementary, ComplementaryRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleContentInfo, ContentInfoRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDate, DateRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDateTime, DateTimeRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDefinition, DefinitionRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDescriptionListDetail, DescriptionListDetailRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDescriptionListTerm, DescriptionListTermRole);
Expand Down Expand Up @@ -279,7 +277,6 @@ COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleTableHeaderContainer, TableHeaderContainer
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleTable, TableRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleTextArea, TextAreaRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleTextField, TextFieldRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleTime, TimeRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleTimer, TimerRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleToggleButton, ToggleButtonRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleToolbar, ToolbarRole);
Expand Down
3 changes: 0 additions & 3 deletions public/web/WebAXEnums.h
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ enum WebAXRole {
WebAXRoleComboBox,
WebAXRoleComplementary,
WebAXRoleContentInfo,
WebAXRoleDate,
WebAXRoleDateTime,
WebAXRoleDefinition,
WebAXRoleDescriptionListDetail,
WebAXRoleDescriptionListTerm,
Expand Down Expand Up @@ -180,7 +178,6 @@ enum WebAXRole {
WebAXRoleTable,
WebAXRoleTextArea,
WebAXRoleTextField,
WebAXRoleTime,
WebAXRoleTimer,
WebAXRoleToggleButton,
WebAXRoleToolbar,
Expand Down

0 comments on commit 0c6b223

Please sign in to comment.