HealLoction Event #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork with source
Changes: - disallow deleting and insertion of heal locations for existing maps - save heal location constants to new headers - added index to HealLocation struct - allow constants for multiple heal locations in same map
|
demo: |
huderlem
reviewed
Sep 6, 2018
event.cpp
Outdated
| @@ -150,6 +163,21 @@ QString Event::buildWarpEventMacro(QMap<QString, QString> *mapNamesToMapConstant | |||
| return text; | |||
| } | |||
|
|
|||
| HealLocation Event::buildHealLocationEventMacro() | |||
There was a problem hiding this comment.
This function's name is not correct. Should be just buildHealLocation?
|
changed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds EventType::HealLocation and icon (#36 ).
The user can move existing heal locations on existing maps but cannot add or replace them.
pokeruby commit
dcf8c33a3b48ede46cf7e96491c0dbc2eb6c8073pokeemerald commit
18d518663061cdb8850d3e41d3d5acae8de7e049