(#1095) Remove code from ctor #1098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@baudoliver7 The tests are failing |
andreoss
suggested changes
Apr 1, 2021
| @@ -532,4 +528,4 @@ SOFTWARE. | |||
| </build> | |||
| </profile> | |||
| </profiles> | |||
| </project> | |||
| </project> | |||
There was a problem hiding this comment.
@baudoliver7 I suggest reverting this part, if xcop doesn't complain than xml formating is fine
| Math.min(8192, this.stream.available()) | ||
| ); | ||
| this.map = this.requests(req); | ||
| this.sstream = new Sticky<>(() -> new RqLengthAware(req).body()); |
There was a problem hiding this comment.
@baudoliver7 Is it possible to use RqOnce on the ctor parameter instead of three Stickies?
It seems also that some fields could be moved inside of request method, such as sbuffer
|
@baudoliver7 what's up with this one? |
|
@yegor256 I have to complete it. Please, just wait a bit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1095
StickyinitializationRqMtFake