Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a problem with the classloader and did some minor refactoring #1300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PeJetuz
Copy link

@PeJetuz PeJetuz commented Jun 28, 2024

@pnatashap @yegor256 Please review, I fixed the classloader issue and did some minor refactoring.

@yegor256
Copy link
Owner

@pnatashap what do you think about this one?

@PeJetuz
Copy link
Author

PeJetuz commented Jul 3, 2024

@pnatashap @yegor256
Maybe I should change:
<exclude>duplicatefinder:org.apache.xmlgraphics:batik-ext:1.7|org.w3c.dom.*</exclude>

for this option:
<exclude>duplicatefinder_ignoredResourcePatterns:about.htmlindex.html</exclude>
<exclude>duplicatefinder_ignoredClassPatterns:org.w3c.dom.*|org.codehaus.plexus.configuration.PlexusConfiguration</exclude>
<exclude>duplicatefinder_ignoredDependency:org.apache.xmlgraphics:batik-ext:1.7|xml-apis:xml-apis:1.0.0</exclude>

or a little shorter:
<exclude>duplicatefinder_resourcePatterns:about.htmlindex.html</exclude>
<exclude>duplicatefinder_classPatterns:org.w3c.dom.*|org.codehaus.plexus.configuration.PlexusConfiguration</exclude>
<exclude>duplicatefinder_dependency:org.apache.xmlgraphics:batik-ext:1.7|xml-apis:xml-apis:1.0.0</exclude>
?
The ignoredResourcePatterns, ignoredClassPatterns and ignoredDependencies parameters correspond to the plugin settings.

@PeJetuz
Copy link
Author

PeJetuz commented Aug 15, 2024

@yegor256 @pnatashap ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants