-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring out a test base for scaling tests #1277
base: master
Are you sure you want to change the base?
Conversation
@IlyaPechersky File with tests become too long, please create one file in addition
|
@IlyaPechersky actually, #1264 was about something else: we want Qulice to ignore binary files (like PNG, JPEG, or PDF) and don't complain about them. However, your pull request is also interesting, I think we should make it good and then merge. |
@yegor256 I realized, it turns out I was really solving another problem) |
qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleMetainfoTest.java
Outdated
Show resolved
Hide resolved
@pnatashap please, help us review this |
qulice-checkstyle/src/test/java/com/qulice/checkstyle/Common.java
Outdated
Show resolved
Hide resolved
qulice-checkstyle/src/test/java/com/qulice/checkstyle/Common.java
Outdated
Show resolved
Hide resolved
qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleMetainfoTest.java
Outdated
Show resolved
Hide resolved
qulice-checkstyle/src/main/resources/com/qulice/checkstyle/checks.xml
Outdated
Show resolved
Hide resolved
qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.java
Outdated
Show resolved
Hide resolved
qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.java
Outdated
Show resolved
Hide resolved
@pnatashap do you have any other issues? |
@yegor256, Are there any more issues? |
qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleMetainfoTest.java
Outdated
Show resolved
Hide resolved
@pnatashap can you please take a look one more time? |
In this request, two problems were solved at once: making a test base and adding tests for content in files, so for now I have left the solution to only one problem - making a test base |
@yegor256 I left only one problem Is there something else to add? |
qulice-checkstyle/src/test/java/com/qulice/checkstyle/CheckstyleValidatorTest.java
Outdated
Show resolved
Hide resolved
@yegor256 Thanks for the article! Replaced inheritance with a utility class |
@IlyaPechersky utility classes are also a bad idea in OOP: https://www.yegor256.com/2014/05/05/oop-alternative-to-utility-classes.html |
If I understood the request from #1264 correctly, we need to reject files with binary code.
To do this, I added a new check in checks.xml , and also added a test with a new one.a java file with binary code.