Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-npm): add resolver for converting locators with __archiveUrl #6525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BasixKOR
Copy link
Contributor

What's the problem this PR addresses?

PatchResolver assumes every source locator it has will work as a descriptor too, but it is not a case with npm: locators with __archiveUrl added.

As a result, when you patch a package with __archiveUrl appended, it will not work because there are no resolvers handling descriptors with __archiveUrl.

Fixes #4711.
...

How did you fix it?

This PR adds a stub implementation for resolving descriptors with __archiveUrl and just converting them into locators.

...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis
Copy link
Member

arcanis commented Oct 1, 2024

Can you look to add a test? You can use the unconventional-tarball package from within the tests to get a package that generates an __archiveUrl locator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: yarn patch generated unparsable patch: URL
2 participants