Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cccl: add package #5978

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

cccl: add package #5978

wants to merge 1 commit into from

Conversation

star-hengxing
Copy link
Contributor

add_requires("cccl[cmake=n]")
#include <thrust/version.h>
#include <cub/version.cuh>
#include <cuda/version>

close #5961

@star-hengxing star-hengxing requested a review from xq114 December 14, 2024 09:22
on_install(function (package)
if package:config("cmake") then
-- TODO: preset support >= v2.7.0
local configs = {"--preset", "install"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

            local configs = {}
            if package:is_debug() then 
                table.insert(configs, "all-dev-debug")
            else
                table.insert(configs, "all-dev")
            end

c.f. https://github.com/NVIDIA/cccl/blob/main/CMakePresets.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(on load?)

@xq114
Copy link
Contributor

xq114 commented Dec 15, 2024

这个最好加上on_fetch,CUDA Toolkit自带cccl (其实xmake-repo不加这个包也没关系,CUDA默认就有,能直接用)

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


It is best to add on_fetch for this, CUDA Toolkit comes with cccl (in fact, it doesn’t matter if xmake-repo does not add this package, CUDA has it by default and can be used directly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thrust has been archived , maybe xrepo should redirect it to cccl/thrust in future ;same as cub
4 participants