修复了一些可能导致奔溃的问题

xiaojieonly · Nov 22, 2024 · eb39135 · eb39135
1 parent d451fc6
commit eb39135
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 20 deletions.
diff --git a/app/src/main/java/com/hippo/app/EditTextDialogBuilder.kt b/app/src/main/java/com/hippo/app/EditTextDialogBuilder.kt
@@ -61,8 +61,8 @@ class EditTextDialogBuilder @SuppressLint("InflateParams") constructor(
         return mDialog!!
     }
 
-    override fun onEditorAction(v: TextView, actionId: Int, event: KeyEvent): Boolean {
-        if (mDialog != null) {
+    override fun onEditorAction(v: TextView, actionId: Int, event: KeyEvent?): Boolean {
+        if (event != null && mDialog != null) {
             val button = mDialog!!.getButton(DialogInterface.BUTTON_POSITIVE)
             button?.performClick()
             return true

diff --git a/app/src/main/java/com/hippo/drawable/PreciselyClipDrawable.kt b/app/src/main/java/com/hippo/drawable/PreciselyClipDrawable.kt
@@ -92,9 +92,10 @@ class PreciselyClipDrawable(
     override fun draw(canvas: Canvas) {
         if (mClip) {
             if (!mScale.isEmpty) {
-                val rect = bounds
-                canvas.clipRect(rect)
+                val saveCount = canvas.save()
+                canvas.clipRect(bounds)
                 super.draw(canvas)
+                canvas.restoreToCount(saveCount)
             }
         } else {
             super.draw(canvas)

diff --git a/app/src/main/java/com/hippo/ehviewer/download/DownloadService.kt b/app/src/main/java/com/hippo/ehviewer/download/DownloadService.kt
@@ -97,7 +97,11 @@ class DownloadService : Service(), DownloadManager.DownloadListener {
         }
     }
 
-    override fun onStartCommand(intent: Intent, flags: Int, startId: Int): Int {
+    override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int {
+        if (intent == null) {
+            // Handle the case where the intent is null
+            return START_STICKY
+        }
         handleIntent(intent)
         return START_STICKY
     }

diff --git a/app/src/main/java/com/hippo/lib/image/Image.kt b/app/src/main/java/com/hippo/lib/image/Image.kt
@@ -193,23 +193,36 @@ class Image private constructor(
 
     fun texImage(init: Boolean, offsetX: Int, offsetY: Int, width: Int, height: Int) {
         check(!hardware) { "Hardware buffer cannot be used in glgallery" }
-        val bitmap: Bitmap = if (animated) {
-            updateBitmap()
-            mBitmap!!
-        } else {
-            if (mObtainedDrawable == null) {
-                return
+        try {
+            val bitmap: Bitmap = if (animated) {
+                updateBitmap()
+                mBitmap!!
+            } else {
+                if (mObtainedDrawable == null) {
+                    return
+                }
+                if (mObtainedDrawable is BitmapDrawable){
+                    (mObtainedDrawable as BitmapDrawable).bitmap
+                }else{
+                    val stickerBitmap = Bitmap.createBitmap(mObtainedDrawable!!.intrinsicWidth, mObtainedDrawable!!.intrinsicHeight, Bitmap.Config.ARGB_8888)
+                    val canvas = Canvas(stickerBitmap)
+                    mObtainedDrawable!!.setBounds(0, 0, stickerBitmap.width, stickerBitmap.height)
+                    mObtainedDrawable!!.draw(canvas)
+                    stickerBitmap
+                }
             }
-            (mObtainedDrawable as BitmapDrawable).bitmap
+            nativeTexImage(
+                bitmap,
+                init,
+                offsetX,
+                offsetY,
+                width,
+                height
+            )
+        }catch (e:ClassCastException){
+            FirebaseCrashlytics.getInstance().recordException(e)
+            return
         }
-        nativeTexImage(
-            bitmap,
-            init,
-            offsetX,
-            offsetY,
-            width,
-            height
-        )
     }
 
     fun start() {