Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Demo that can use a matrix to control FilterView #534

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

phcbest
Copy link
Contributor

@phcbest phcbest commented Sep 30, 2024

Add corresponding implementation for the issue #533

@wysaid
Copy link
Owner

wysaid commented Sep 30, 2024

👍👍👍 这几天国庆假期, 稍晚几天review~~

@wysaid
Copy link
Owner

wysaid commented Oct 6, 2024

Hello, 今天运行了一下你的新demo, 界面上看似未能体现出来功能, 你看看能否稍微改改, 让这个 demo 界面也像其他几个样例那样, 能够切换一下滤镜呢?
🫶

@phcbest
Copy link
Contributor Author

phcbest commented Oct 6, 2024

Hello, 今天运行了一下你的新demo, 界面上看似未能体现出来功能, 你看看能否稍微改改, 让这个 demo 界面也像其他几个样例那样, 能够切换一下滤镜呢? 🫶

我已经完成了修改并且Commit了,您可以看一下,对Demo添加了滤镜切换和强度调整功能🤗

@wysaid
Copy link
Owner

wysaid commented Oct 8, 2024

改了两个地方:

  • 不添加新图片, 复用原来的
  • 调整了一下 slider 的层级, 放到图像上方

你再看看, 没问题就合入了。

@phcbest
Copy link
Contributor Author

phcbest commented Oct 8, 2024

ok没问题,您直接合吧

@wysaid wysaid merged commit b210a50 into wysaid:master Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants