Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIGW instance #81

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add APIGW instance #81

wants to merge 1 commit into from

Conversation

dockerised
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Kong API GW for dev

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Member

@jterry64 jterry64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dockerised could this just be added in fw_core_infrastructure instead? I don't think this needs to be in this repo

@tanderegg
Copy link
Member

@dockerised Agreed this should be in fw_core_infrastructure as this API GW is specific to the FW app, seems it might have been at one point? https://github.com/wri/fw_core_infrastructure/blob/production/terraform/apigw.tf Let us know if there's a reason it needs to be here instead, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants