Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write out raw bytes, not human-readable u8 arrays. #6

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

BenModulusLabs
Copy link
Collaborator

This is to align with what seems to be the format of a self-custody package.

@BenModulusLabs
Copy link
Collaborator Author

There is something strange going on with cargo fmt CI - it is passing locally for me. Line length?

Copy link
Collaborator

@NayrOacModulus NayrOacModulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@NayrOacModulus NayrOacModulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again!

Copy link
Contributor

@vishady721 vishady721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slayyyy

@BenModulusLabs BenModulusLabs merged commit f132bcd into main Oct 30, 2024
3 checks passed
@BenModulusLabs BenModulusLabs deleted the raw-binary branch October 30, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants