Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI #2

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add CI #2

merged 1 commit into from
Oct 11, 2024

Conversation

TheButlah
Copy link
Contributor

@TheButlah TheButlah commented Oct 10, 2024 •
edited
Loading

This PR does the following:

  • pins the rust toolchain to latest stable. Ensures that over time as rust updates, CI won't break. Updating rust can be done at any time by updating the toolchain.
  • Sets the "Minimum supported rust version" to be the latest. I don't actually know which rust version is the oldest one you wish to support, so I figured setting it to the latest would be fine.
  • Adds CI to check that all dependencies are permissively licensed (aka no GPL)
  • Adds CI to ensure that code complies with the format declared in rustfmt.toml

@TheButlah TheButlah force-pushed the thebutlah/add-cargo-deny branch 2 times, most recently from 7297f8d to 320c669 Compare October 10, 2024 22:26
@TheButlah TheButlah changed the title add cargo deny check to CI Add CI Oct 10, 2024
@TheButlah TheButlah force-pushed the thebutlah/add-cargo-deny branch 4 times, most recently from 79c54d6 to a55c384 Compare October 10, 2024 22:50
@TheButlah TheButlah mentioned this pull request Oct 10, 2024
Merged
4 tasks
@TheButlah TheButlah marked this pull request as ready for review October 10, 2024 23:14
@TheButlah TheButlah changed the base branch from master to main October 11, 2024 18:46
NayrOacModulus
NayrOacModulus approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@NayrOacModulus NayrOacModulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@TheButlah TheButlah merged commit dfad28b into main Oct 11, 2024
7 checks passed
@TheButlah TheButlah deleted the thebutlah/add-cargo-deny branch October 11, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NayrOacModulus NayrOacModulus NayrOacModulus approved these changes

@vishady721 vishady721 Awaiting requested review from vishady721

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheButlah @NayrOacModulus