Update feedback form note #21489
Merged
Update feedback form note #21489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21489-b02e3d9 | |
| Commit | b02e3d9 | |
| Direct Download | jetpack-prototype-build-pr21489-b02e3d9.apk |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21489-b02e3d9 | |
| Commit | b02e3d9 | |
| Direct Download | wordpress-prototype-build-pr21489-b02e3d9.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21489 +/- ##
=======================================
Coverage 39.44% 39.44%
=======================================
Files 2121 2121
Lines 99564 99564
Branches 15313 15313
=======================================
Hits 39277 39277
Misses 56806 56806
Partials 3481 3481 ☔ View full report in Codecov by Sentry. |
jkmassel
approved these changes
Nov 25, 2024
| @@ -1148,7 +1148,8 @@ | |||
| <string name="feedback_form_attachment_already_added">Attachment already added</string> | |||
| <string name="feedback_form_unable_to_create_tempfile">Unable to create temporary file</string> | |||
| <string name="feedback_form_add_attachments">Add attachments</string> | |||
| <string name="feedback_form_note">If you need support, please get in touch using the \"Contact Support\" screen</string> | |||
| <string name="feedback_form_note_text">Please note this is not a support form, and we will not be able to reply. If you need support, please use our "</string> | |||
There was a problem hiding this comment.
What is the trailing " for?
There was a problem hiding this comment.
It's a trailing space, because feedback_form_note_link ("Contact Support screen") is appended to this string as a link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21475
This PR updates the feedback form so that the note about the form not being for support is more prominent and more clearly worded. It also adds a link to the "Contact Support" screen.
When the link is clicked, I simply return the user to the Help screen where the user can see and tap the "Contact Support" link. I chose to do this to inform the user where "Contact Support" is, but I was torn between doing that or going straight to the support screen. Opinions welcome!