Skip to content

Commit

Permalink
Move redirect URI into build.grade
Browse files Browse the repository at this point in the history
It’s not a secret
  • Loading branch information
jkmassel committed Nov 28, 2024
1 parent e08ae1f commit ebe5b84
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions WordPress/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ android {
buildConfigField "String", "PUSH_NOTIFICATIONS_APP_KEY", '"org.wordpress.android"'
buildConfigField "boolean", "ENABLE_QRCODE_AUTH_FLOW", "false"
buildConfigField "boolean", "ENABLE_OPEN_WEB_LINKS_WITH_JP_FLOW", "true"
buildConfigField "String", "WPCOM_REDIRECT_URI", '"wordpress://wpcom-authorize"'

manifestPlaceholders = [magicLinkScheme:"wordpress"]
}
Expand All @@ -229,6 +230,7 @@ android {
buildConfigField "String", "PUSH_NOTIFICATIONS_APP_KEY", '"com.jetpack.android"'
buildConfigField "boolean", "ENABLE_QRCODE_AUTH_FLOW", "true"
buildConfigField "boolean", "ENABLE_OPEN_WEB_LINKS_WITH_JP_FLOW", "false"
buildConfigField "String", "WPCOM_REDIRECT_URI", '"jetpack://wpcom-authorize"'

manifestPlaceholders = [magicLinkScheme:"jetpack"]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import android.content.Context;
import android.util.Base64;

import androidx.annotation.NonNull;

import com.goterl.lazysodium.utils.Key;
Expand All @@ -26,7 +27,7 @@
public class AppConfigModule {
@NonNull @Provides
public AppSecrets provideAppSecrets() {
return new AppSecrets(BuildConfig.OAUTH_APP_ID, BuildConfig.OAUTH_APP_SECRET, BuildConfig.OAUTH_REDIRECT_URI);
return new AppSecrets(BuildConfig.OAUTH_APP_ID, BuildConfig.OAUTH_APP_SECRET, BuildConfig.WPCOM_REDIRECT_URI);
}

@Singleton
Expand Down

0 comments on commit ebe5b84

Please sign in to comment.