wolfHSM support for ML-DSA #523
Conversation
|
Converting to draft until @danielinux merges #521 |
- consolidate AURIX scripts into wbaurixtool.sh - documentation updates
bigbrett
force-pushed
the
wolfhsm-mldsa
branch
from
04682a0 to
ace953a
Compare
|
rebased after #521 was merged, re-tested on Sim + AURIX. Ready for review |
bigbrett
requested review from
danielinux and
dgarske
and removed request for
danielinux
tools/keytools/keygen.c
Outdated
| if (saveAsDer) { | ||
| /* Export public key in DER format */ | ||
| uint8_t pubDer[ | ||
| #if ML_DSA_LEVEL == 2 |
There was a problem hiding this comment.
These come from run-time arguments now. You might need to rebase and fix this.
There was a problem hiding this comment.
oops. Already had rebased but forgot to change this line. Fixed in latest commit to switch on ml_dsa_level
bigbrett
force-pushed
the
wolfhsm-mldsa
branch
from
94d13b4 to
3148d36
Compare
tools/keytools/keygen.c
Outdated
| exit(1); | ||
| break; | ||
| } | ||
| pubDer = malloc(pubDerSz); |
There was a problem hiding this comment.
added in latest commit. Didn't realize this was in our coding standard, but indeed it is. Just of curiosity why do we do this? For C++ compatibility?
| pubOutLen = wc_Dilithium_PublicKeyToDer(&key, pubDer, pubDerSz, | ||
| WITH_ALG_SPKI); | ||
| if (pubOutLen < 0) { | ||
| fprintf(stderr, "Unable to export public key to DER, ret=%d\n", |
There was a problem hiding this comment.
Do you want to free pubDer?
There was a problem hiding this comment.
we immediately exit(1) on any failure, so didn't free. Just following the paradigm elsewhere in keygen.c.
wbaurixtool.sh, a one-stop-shop configuration tool that handles the manual configuration steps that aren't handled by AURIX IDENote that this requires updating wolfSSL to include wolfSSL/wolfssl#8177 and wolfSSL/wolfssl#8229. If we need to wait until the required changes are incorporated in a release, let me know and this can remain a draft PR