add quotes around $GITHUB_ENV and $GITHUB_OUTPUT

wlav · Sep 13, 2023 · 8c774b1 · 8c774b1
1 parent b42a798
commit 8c774b1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/.github/workflows/cling-wheels.yml b/.github/workflows/cling-wheels.yml
@@ -18,7 +18,7 @@ jobs:
         id: aarch64-job-number
         run: |
           export JOB_NUMBER=$(python3 circleci.py job --token ${{ secrets.CIRCLE_API_TOKEN }})
-          echo "job_number=$JOB_NUMBER" >> $GITHUB_OUTPUT
+          echo "job_number=$JOB_NUMBER" >> "$GITHUB_OUTPUT"
 
   build_wheels:
     name: Build wheels on ${{ matrix.cibw.build }}
@@ -158,7 +158,7 @@ jobs:
           JOB_NUMBER: ${{ needs.build-aarch64-wheels.outputs.job_number }}
         run: |
           export WHEEL_PATH=$(python circleci.py artifact --job-number $JOB_NUMBER --token ${{ secrets.CIRCLE_API_TOKEN }})
-          echo "wheel_path=$WHEEL_PATH" >> $GITHUB_ENV
+          echo "wheel_path=$WHEEL_PATH" >> "$GITHUB_ENV"
 
       - uses: actions/upload-artifact@v3
         with:

diff --git a/circleci.py b/circleci.py
@@ -35,10 +35,7 @@ def get_artifact(
 
     urllib.request.urlretrieve(url, path)
     time.sleep(1.0)
-    if not path:
-        print('wheelhouse/cppyy_cling-6.28.0-py2.py3-none-linux_aarch64.whl')
-    else:
-        print(path)
+    print(path)
     return 0