-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v5): broken link and missing type annotations in tutorial #10119
fix(v5): broken link and missing type annotations in tutorial #10119
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌑 This pull request will not trigger status changes. Learn moreLunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: You can change this by either removing the keyword above from the PR's title, or modifying the Tracked FilesNote The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catches, thanks! And yes, we are still making high-value emergency fixes to 5.0 docs! Thank you very much for this!
I'm just rerunning the Netlify deploy to see if I can get it to work before merging. We're getting the "out of memory" error again. |
Second Netlify deployment is fine! 🚀 |
I know we're not supposed to send PRs right now, but since I noticed some errors while I did the tutorial again (see withastro/blog-tutorial-demo#33), I thought I'd make the necessary updates!
Description (required)
Updates the tutorial to:
I haven't addressed
ThemeIcon.astro
because I don't know if it's necessary or not:blog-tutorial-demo
I see Typescript errors...Related issues & labels (optional)
Sorry for the wrong automatic labels... I forgot to use the
5.0.0
branch as base... 😅