Bloodhound / Opensearch #4261
Draft
Bloodhound / Opensearch #4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersven
added
the
ok-to-test
supersven
force-pushed
the
supersven/bloodhound-opensearch
branch
2 times, most recently
from
7669b04
to
4b643a3
Compare
supersven
force-pushed
the
supersven/bloodhound-opensearch
branch
2 times, most recently
from
f331e51
to
1f6823e
Compare
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
supersven
commented
Oct 16, 2024
| updateTeamSearchVisibilityInboundImpl :: forall r. (Member (Embed IO) r) => IndexedUserStoreConfig -> TeamId -> SearchVisibilityInbound -> Sem r () | ||
| updateTeamSearchVisibilityInboundImpl cfg tid vis = | ||
| void $ runInBothES cfg updateAllDocs | ||
| where | ||
| updateAllDocs :: ES.IndexName -> ES.BH (Sem r) () | ||
| updateAllDocs idx = do | ||
| r <- ES.updateByQuery idx query (Just script) | ||
| r <- hoistBH (embed @IO) $ ES.performBHRequest . fmap fst . ES.keepBHResponse $ ESR.updateByQuery @Value idx query (Just script) |
There was a problem hiding this comment.
This handling of version conflicts is probably broken here. See bitemyapp/bloodhound#295
supersven
force-pushed
the
supersven/bloodhound-opensearch
branch
from
2b268b2
to
91ef5f0
Compare
fisx
reviewed
Oct 18, 2024
| networks: | ||
| - demo_wire | ||
|
|
||
| opensearch-dashboard: |
There was a problem hiding this comment.
dashboard! neat! is there a good place to mention that so people might notice?
There was a problem hiding this comment.
The Developer how-to's[sic] seem to be a good place: https://github.com/wireapp/wire-server/pull/4261/files#diff-9d61e022388a68889ab4d5f60ae707d533693274a2c21540162c00e9e528f497R215
fisx
reviewed
Oct 18, 2024
libs/wire-subsystems/src/Wire/IndexedUserStore/MigrationStore/ElasticSearch.hs
Outdated
Show resolved
Hide resolved
libs/wire-subsystems/src/Wire/IndexedUserStore/MigrationStore/ElasticSearch.hs
Outdated
Show resolved
Hide resolved
| case persistResponse of | ||
| Left _ -> throw $ PersistVersionFailed v $ show persistResponse | ||
| Right r -> | ||
| if ES.idxDocId r == docIdText |
There was a problem hiding this comment.
Shouldn't this still do something involving ES.isCreated?
Comment on lines
139
to
140
| castResponse :: forall context1 val1 context2 val2. BHResponse context1 val1 -> BHResponse context2 val2 | ||
| castResponse BHResponse {..} = BHResponse {..} |
There was a problem hiding this comment.
Huh? How does this work without casting the fields?
There was a problem hiding this comment.
It's about casting phantom types. However, I've refactored this part to make it better understandable (Your question was an important hint!)
-- | Parse `BHResponse` as `ES.EsError`
parseESError :: BHResponse ES.StatusDependant any -> Either ES.EsProtocolException ES.EsError
parseESError res = either id id <$> ES.parseEsResponse (castResponse res)
where
castResponse :: BHResponse ES.StatusDependant any -> BHResponse ES.StatusDependant ES.EsError
castResponse BHResponse {..} = BHResponse {..}
fisx
requested changes
Oct 23, 2024
supersven
force-pushed
the
supersven/bloodhound-opensearch
branch
3 times, most recently
from
9c29e8c
to
8eb8c42
Compare
supersven
force-pushed
the
supersven/bloodhound-opensearch
branch
2 times, most recently
from
a21d71b
to
b58a7d5
Compare
supersven
force-pushed
the
supersven/bloodhound-opensearch
branch
2 times, most recently
from
d1a5104
to
ad27cff
Compare
mdimjasevic
approved these changes
Nov 25, 2024
deploy/dockerephemeral/docker/opensearch/opensearch-security/internal_users.yml
Show resolved
Hide resolved
supersven
force-pushed
the
supersven/bloodhound-opensearch
branch
from
fcd0f1a
to
857328d
Compare
The latest master of Bloodhound contains a fix regarding parsing responses that we need to use OpenSearch 1.x. Unfortunately, the interface of this library changed a lot.
This will be our new target, to be used on-prem and in the Wire cloud.
This includes adding the OpenSearch Dashboards (for better visibility and debugging purposes.)
This reflects the prior behaviour.
Won't be compatible to OpenSearch. And, users should setup their services on their own. Fix
This fits better into the Parser picture: If a value is invalid, fail in parsing - don't throw errors later.
supersven
force-pushed
the
supersven/bloodhound-opensearch
branch
from
857328d
to
1230a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be released in combination with an infrastructure migration from ElasticSearch 6 to OpenSearch 1.3.
Ticket: https://wearezeta.atlassian.net/browse/WPB-10715
Checklist
changelog.d