add welcome user option #391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NovemLinguae
requested changes
Nov 7, 2024
Fixed grammar in welcome message category
| if ( teahouse ) { | ||
| message += '\n\n' + AFCH.msg.get( 'teahouse-invite' ); | ||
| } | ||
| $.when( shouldTeahouse, shouldWelcomeUser ).then( ( teahouse, welcome ) => { |
There was a problem hiding this comment.
I think I found a bug.
On the master branch, if I do this, the subumitter gets the decline message on their user talk.
With this patch loaded, if I do this, the submitter gets zero messages posted to their user talk.
Can you fix when you get a chance?
There was a problem hiding this comment.
I will fix it this weekend.
| @@ -300,6 +300,10 @@ | |||
| <input type="checkbox" id="notifyUser" class="afch-input" checked/> | |||
| <label for="notifyUser" class="afch-label">Notify submitter</label> | |||
| </div> | |||
| <div class="afch-option"> | |||
| <input type="checkbox" id="sendWelcome" class="afch-input" checked/> | |||
There was a problem hiding this comment.
Per https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_creation#Welcome_template, can we please make this unticked by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #386