Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax-highlight ABNF too #83

Merged
merged 2 commits into from
Aug 21, 2018
Merged

Syntax-highlight ABNF too #83

merged 2 commits into from
Aug 21, 2018

Conversation

domenic
Copy link
Member

@domenic domenic commented Aug 13, 2018

Follows whatwg/html#3911.

sideshowbarker
sideshowbarker reviewed Aug 20, 2018
View reviewed changes
Copy link
Contributor

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs handling added in the WalkOut code, right? In the if/then/else that starts around line 1975

@domenic
Copy link
Member Author

domenic commented Aug 21, 2018

Thanks, fixed!

@sideshowbarker sideshowbarker merged commit 64628d1 into master Aug 21, 2018
@sideshowbarker sideshowbarker deleted the highlight-abnf branch August 21, 2018 23:20
@sideshowbarker
Copy link
Contributor

Sorry, I should have squashed this before merging :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domenic @sideshowbarker