Skip to content

Commit

Permalink
Give up on TypeError battle. https://www.w3.org/Bugs/Public/show_bug.…
Browse files Browse the repository at this point in the history 
…cgi?id=24028
  • Loading branch information
@annevk
annevk committed May 22, 2014
1 parent 333b03c commit 39c2927
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Overview.src.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5788,8 +5788,8 @@ <h3>Interface <code>Element</code></h3>
<span data-anolis-spec=selectors>parse a selector</span> from <var title>selectors</var>.
<span data-anolis-ref>SELECTORS</span>

<li><p>If <var title>s</var> is failure, <span data-anolis-spec=webidl>throw</span> a
JavaScript <code title>TypeError</code>.
<li><p>If <var title>s</var> is failure, <span title=concept-throw>throw</span> a
"<code>SyntaxError</code>".

<li><p>Return the result of <span data-anolis-spec=selectors>evaluate a selector</span>
<var title>s</var> using
Expand Down
8 changes: 4 additions & 4 deletions dom-core.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<hgroup>
<h1 class="allcaps">DOM</h1>
<h2>Living Standard — Last Updated 19 May 2014</h2>
<h2>Living Standard — Last Updated 22 May 2014</h2>
</hgroup>

<dl>
Expand Down Expand Up @@ -44,7 +44,7 @@ <h2>Living Standard — Last Updated 19 May 2014</h2>
<p class="copyright"><a href="http://creativecommons.org/publicdomain/zero/1.0/" rel="license"><img alt="CC0" src="http://i.creativecommons.org/p/zero/1.0/80x15.png"></a>
To the extent possible under law, the editors have waived all copyright and
related or neighboring rights to this work. In addition, as of
19 May 2014, the editors have made this specification available
22 May 2014, the editors have made this specification available
under the
<a href="http://www.openwebfoundation.org/legal/the-owf-1-0-agreements/owfa-1-0" rel="license">Open Web Foundation Agreement Version 1.0</a>,
which is available at
Expand Down Expand Up @@ -5862,8 +5862,8 @@ <h3 id="interface-element"><span class="secno">5.8 </span>Interface <code><a hre
<a class="external" data-anolis-spec="selectors" href="http://dev.w3.org/csswg/selectors/#parse-a-selector">parse a selector</a> from <var title="">selectors</var>.
<a href="#refsSELECTORS">[SELECTORS]</a>

<li><p>If <var title="">s</var> is failure, <a class="external" data-anolis-spec="webidl" href="http://heycam.github.io/webidl/#dfn-throw">throw</a> a
JavaScript <code title="">TypeError</code>.
<li><p>If <var title="">s</var> is failure, <a href="#concept-throw" title="concept-throw">throw</a> a
"<code><a href="#syntaxerror">SyntaxError</a></code>".

<li><p>Return the result of <a class="external" data-anolis-spec="selectors" href="http://dev.w3.org/csswg/selectors/#evaluate-a-selector">evaluate a selector</a>
<var title="">s</var> using
Expand Down

4 comments on commit 39c2927

@domenic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes make it a DOMException, instead of a normal SyntaxError?

@annevk
Copy link
Member Author

@annevk annevk commented on 39c2927 May 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition of concept-throw does.

@sideshowbarker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ms2ger Does this require a wpt DOM test to be updated?

@Ms2ger
Copy link
Member

@Ms2ger Ms2ger commented on 39c2927 May 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selectors-api/tests/submissions/Opera/level2-lib.js already seems to test for SyntaxError.

Please sign in to comment.