Automatically syncing after database error #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2012 15:07
pgsql_connection processes will automatically initiate a Postgres sync exchange with the database when a database error occurs. This insures the connection is always in a sane state and relieves external callers from having to care about syncing the connection after an error.
|
Hi Kevin, thanks for the pull request! I'm curious about what sort of errors you've encountered that could benefit from this, is it during binding parameters to a prepared statement or something else? I wonder if there are any cases where you wouldn't want to automatically issue a sync... |
|
@kevsmith I'm curious as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been happy with epgsql but the need to manually sync after an error has caused us a few problems. These two commits enable pgsql_connection to automatically initiate a database sync in the event of a database error.