Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for composer plugin api 2 , Drop support PHP 7 and composer version 1 #2

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

luislard
Copy link

Closes #1

@luislard luislard changed the title Drop support PHP 7 and composer version 1 Add support for composer plugin api 2 , Drop support PHP 7 and composer version 1 Nov 27, 2023
@gmazzap
Copy link
Member

gmazzap commented Dec 10, 2023

@luislard is there any reason why this is in draft, are you planning more work before you consider it mergeable?

@luislard
Copy link
Author

@luislard is there any reason why this is in draft, are you planning more work before you consider it mergeable?

Yes,

  1. I didn't know if the maintainers want to go this way.

  2. I would suggest to create a new major version branch to merge this branch to. Maybe a 2.x branch

After having a 2.x branch I will switch the target and move from the draft state.

@gmazzap
Copy link
Member

gmazzap commented Dec 12, 2023

@luislard I think this is simpler enough to be managed on single branch.

We can just release v2 with the changes, and that's it.

This could be a breaking change for people who require the package via dev-master, but there was backward compatibility promise on the master branch, so nobody should be done this and expect backward compatibility.

Also this package has 304 downloads in 7 years, and I'm sure I'm responsible myself for a good potion of those, so let's not make things more complicated they need to be.

The Pr looks fine to me, but we probably needs some test to make sure the code actuall work with the whole matrix of dependencies we are commiting to.

That means PHP 8.0 - 8.3 and Composer 2.0 - 2.6, those are 24 combinations if I'm not mistaken, and we should have basic tests checking for all of them.

@luislard luislard changed the base branch from master to v2.x December 14, 2023 11:11
@gmazzap gmazzap marked this pull request as ready for review December 14, 2023 11:11
@gmazzap gmazzap merged commit 5c9bbc5 into wecodemore:v2.x Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Make it compatible with composer plugin api v2
2 participants