This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2
Added functionality to choose one dependency from the list #8
Open
michalbundyra
wants to merge
7
commits into
master
Choose a base branch
from
feature/dependency-or
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basz
reviewed
Nov 10, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't follow every code thread, but looks a nice improvement. Am I correct in that the plugin now also looks at dependencies other then those in the root composer.json.
@basz the plugin before also looks for installed dependencies, not only these defined in root composer. Change in this PR provide functionality to choose between packages to install (and as you know - I'm going to use it in |
Before we run update composer internally after every package which requires extra dependencies. Now we run it only once, at the end - on post command (install/update).
michalbundyra
force-pushed
the
feature/dependency-or
branch
from
November 12, 2017 13:05
aed95a0
to
b90d35a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature. Now we can define list of dependencies and give user a choice which one should be installed.
In case your library is compatible with many libraries, and you want force user to choose one of them and give them a list of supported libraries to choose. Configuration for this new feature is the following (
extra
section incomposer.json
):And user on composer update will be prompted with "Question" and list of packages:
User will be prompted only when none of these packages are not installed. If there is at least one package installed or defined in root composer user will be not prompted.
/cc @basz @weierophinney