Reland "Fenced frame: Fix some WPTs in headless mode." #48701
+88
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original CL was crashing in an instance where multiClick() was invoked without an await. This fixes the crash by awaiting the clicks instead of continuing with/finishing the test before all the clicks have propagated inside navigate-ancestor-test-runner.https.html. Original change's description: > Fenced frame: Fix some WPTs in headless mode. > > There is currently a push to allow Chromium web platform tests to run > in headless mode (i.e. without a content shell). This requires some > changes to how fenced frame tests work. Headless mode does not support > test_driver functions from inside of fenced frames, as those require > access to the main frame's window to pass the message onto, which > fenced frames deliberately block for privacy reasons. This CL fixes > some of the tests that fail in headless mode by moving those > test_driver calls to the main frame, specifically clicking actions > (which we already have multiClick() to handle this in main frames), > and set_permission(). > > See the headless mode explainer: > https://chromium.googlesource.com/chromium/src/+/HEAD/headless/README.md > > Change-Id: Iab82a581b67f8f8851c7716a2d72caf566f3b2ae > Bug: 366257368 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5935060 > Reviewed-by: Andrew Verge <[email protected]> > Commit-Queue: Liam Brady <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1370151} Bug: 366257368 Change-Id: Id998687c2f3de41a7b0dcd5197ba74fb22ef979e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5938155 Reviewed-by: Andrew Verge <[email protected]> Commit-Queue: Liam Brady <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370703}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5938155
branch
from
5400a91
to
4159e9d
Compare
wpt-pr-bot
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original CL was crashing in an instance where multiClick() was
invoked without an await. This fixes the crash by awaiting the clicks
instead of continuing with/finishing the test before all the clicks
have propagated inside navigate-ancestor-test-runner.https.html.
Original change's description:
Bug: 366257368
Change-Id: Id998687c2f3de41a7b0dcd5197ba74fb22ef979e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5938155
Reviewed-by: Andrew Verge <[email protected]>
Commit-Queue: Liam Brady <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1370703}