Only check for matching mode in attachShadow #44562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5283935
branch
3 times, most recently
from
d67e0c4
to
067ec3d
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5283935
branch
4 times, most recently
from
52dff8a
to
3937c3d
Compare
Per the new-new consensus, attachShadow will only verify that the existing declarative shadow root's `mode` matches the newly requested `mode`: whatwg/html#10107 (comment) Bug: 41483062,325598615 Change-Id: Ie3bac4ec297c0b85c40b45495e9c823dd47cb49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5283935 Commit-Queue: Mason Freed <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Di Zhang <[email protected]> Reviewed-by: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1262014}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5283935
branch
from
3937c3d
to
b7ee19a
Compare
wpt-pr-bot
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the new-new consensus, attachShadow will only verify that
the existing declarative shadow root's
modematches the newlyrequested
mode:whatwg/html#10107 (comment)
Bug: 41483062,325598615
Change-Id: Ie3bac4ec297c0b85c40b45495e9c823dd47cb49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5283935
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Di Zhang <[email protected]>
Reviewed-by: Di Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1262014}