Check for matching serializable in attachShadow
#44246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5242281
branch
from
afa0a58
to
65a77a9
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5242281
branch
from
65a77a9
to
000b74c
Compare
chromium-wpt-export-bot
changed the title
serializable in attachShadow
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5242281
branch
2 times, most recently
from
8bfa2cb
to
f83978a
Compare
This parameter was added ([1]) after the initial check code was written ([3]). Note that [2] also added `clonable` but there's an issue [4] about checking that in a similar way. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5239221 [2] https://chromium-review.googlesource.com/c/chromium/src/+/5239277 [3] https://chromium-review.googlesource.com/c/chromium/src/+/5191750 [4] whatwg/html#10107 Bug: 1517959 Change-Id: I689c6a6f84fb7ce298cf187076ae228fef6cc348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5242281 Commit-Queue: David Baron <[email protected]> Reviewed-by: David Baron <[email protected]> Auto-Submit: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1253972}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5242281
branch
from
f83978a
to
c75447d
Compare
wpt-pr-bot
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter was added ([1]) after the initial check code was written
([3]). Note that [2] also added
clonablebut there's an issue [4]about checking that in a similar way.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/5239221
[2] https://chromium-review.googlesource.com/c/chromium/src/+/5239277
[3] https://chromium-review.googlesource.com/c/chromium/src/+/5191750
[4] whatwg/html#10107
Bug: 1517959
Change-Id: I689c6a6f84fb7ce298cf187076ae228fef6cc348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5242281
Commit-Queue: David Baron <[email protected]>
Reviewed-by: David Baron <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1253972}