Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtle striping for table in <wpt-results/> #4089

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

YoshiRulz
Copy link
Contributor

@YoshiRulz YoshiRulz commented Oct 27, 2024

Description

Resolves #1783/#2217 by adding a grey background to every other row in the table.
Before/after:
comparison
Untested because I'm on NixOS and Docker isn't trivial, though based on #3840 I'm guessing it wouldn't have worked anyway. The above screenshot was taken by adding the rule via the dev tools.

Review Information

idk man

Changes

Added a single CSS rule. edit: two now

Requirements

N/A

@KyleJu
Copy link
Collaborator

KyleJu commented Oct 29, 2024

@YoshiRulz Hi James! First of all, thank you for the fix! One minor follow-up: the test names are not vertically centered around the cells. Could you center them?

image

@YoshiRulz
Copy link
Contributor Author

I had a look and it seems non-trivial (path-part { margin: auto 0; } and similar don't work), but in any case that problem isn't related to this changeset and only happens when the viewport is narrow. It is possible to align them to the bottom of the cell with vertical-align though, which IMO reads better, shall I do that?

@KyleJu
Copy link
Collaborator

KyleJu commented Oct 30, 2024

I had a look and it seems non-trivial (path-part { margin: auto 0; } and similar don't work), but in any case that problem isn't related to this changeset and only happens when the viewport is narrow. It is possible to align them to the bottom of the cell with vertical-align though, which IMO reads better, shall I do that?

You are right! I couldn't get it to move after fiddling with the margin and padding in path-part, so feel free to align them to the bottom of the cell with vertical-align. Let me spend more time on it before the end of the week!

Another thing is that on the homepage, it uses a different shade of grey, #EEEEEE

Screenshot 2024-10-30 11 09 43 AM

I would like to make it consistent! Thanks again!

@KyleJu
Copy link
Collaborator

KyleJu commented Nov 4, 2024

Before and after:
Screenshot 2024-11-04 11 25 58 AM
Screenshot 2024-11-04 11 25 09 AM
Screenshot 2024-11-04 11 25 02 AM
Screenshot 2024-11-04 11 24 59 AM

Let me double check with the team! Thanks again!

@KyleJu
Copy link
Collaborator

KyleJu commented Nov 19, 2024

Staging builds:
Screenshot 2024-11-19 11 39 47 AM

Screenshot 2024-11-19 11 39 54 AM

@KyleJu KyleJu merged commit 34e53e4 into web-platform-tests:main Nov 19, 2024
12 checks passed
@KyleJu
Copy link
Collaborator

KyleJu commented Nov 19, 2024

@YoshiRulz Thank you for your patience! Merged your CL and thanks again for the help :)

@YoshiRulz YoshiRulz deleted the striping branch November 19, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to distinguish rows on the result page
2 participants