Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert digestAlgorithm and digestValue overrides. #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert digestAlgorithm and digestValue overrides. #43

wants to merge 1 commit into from

Conversation

davidlehn
Copy link
Member

This reverts 46c2376 due to:

  • Confusion due to the override from v1.
  • digestValue shouldn't be using @vocab.
  • Unclear if digestAlgorithm should be using @vocab and how to
    coordinate on a shared set of values to use.

@davidlehn
Revert digestAlgorithm and digestValue overrides.
885bae6 
This reverts 46c2376 due to:
- Confusion due to the override from v1.
- digestValue shouldn't be using @vocab.
- Unclear if digestAlgorithm should be using @vocab and how to
  coordinate on a shared set of values to use.
dlongley
dlongley approved these changes Aug 23, 2018
View reviewed changes
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this could go either way, I'm fine with reverting and keeping it simple with strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlehn @dlongley