Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modern-module): concatenate entry module regardless bail reasons #8165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fi3ework
Copy link
Member

Summary

If the root module is empty, it will store all bailout reasons of current config

optimization_bailouts.push(self.format_bailout_warning(warning.0, &warning.1));
Previously, this will make root module won't be force concatenated (see new added test case g)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 18, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit ef807ab
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67120c35c6072100086b1ea1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant