Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated fs.rmdir with recursive removal logic #8064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nexckycort
Copy link

Summary

This pull request addresses a deprecation warning in Node.js regarding the use of fs.rmdir(path, { recursive: true }). In future versions, this method will be removed.

To resolve this, I replaced fs.rmdir with fs.rm(path, { recursive: true }) as recommended by the warning. This change maintains the functionality while adhering to future Node.js standards.
image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 8, 2024
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 4d6b4bc
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6704e51ef7b0af0008b483fd

@SoonIter SoonIter self-assigned this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants