feat(rspack): support xtask #7915
Draft
+242
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: feature
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hardfist
reviewed
Sep 24, 2024
| "Api-extractor testing failed. Did you forget to update the snapshots locally?\nRun the command below locally to fix this error (in the *ROOT* of rspack workspace).\n$ ./x api-extractor update" | ||
| })?; | ||
| } | ||
| } |
There was a problem hiding this comment.
what's the benefit of run pnpm script in xtask then in justfile directly
There was a problem hiding this comment.
You can use cmd args more flexibly. This is just a start, and perhaps api-extractor isn't the best choice. I expect to implement commands like debug, publish, and version in xtask.
There was a problem hiding this comment.
I'm not sure put js related task into xtask is a good idea, maybe we should start with rust related task first, @h-a-n-a what's your idea?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #7516
Checklist