Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Windows, synchronize .gitignore and README.md #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lauriharpf
Copy link

Cross-platform compatibility

Makes pnpm run build work on both macOS and Windows platforms. While creating the reproduce repo for web-infra-dev/rspack#8170, I noticed that pnpm run build worked on macOS but failed on Windows.

On Windows, the error messages from pnpm run build initially were

Unknown arguments: =1, pnpm, rspack
 ELIFECYCLE  Command failed with exit code 1.
ERROR: "build:rspack" exited with 1.
 ELIFECYCLE  Command failed with exit code 1.

Those errors were fixed by adding cross-env. After that, the build:rsbuild step still failed on Windows with the following error message (fixed with the --env-mode development):

  Rsbuild v1.0.1
  
error   Failed to build.
error   'local' cannot be used as a value for env mode, because ".env.local" represents a temporary local file. Please use another value.

.gitignore and README.md synchronization

Remove rspack-dist and webpack-dist from .gitignore to be in sync with README.md ("./webpack-dist and ./rspack-dist are purposely not added to .gitignore.")

- Remove rspack-dist and webpack-dist from .gitignore to be in sync with README.md ("`./webpack-dist` and `./rspack-dist` are purposely not added to `.gitignore`.")
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants