Fix build on Windows, synchronize .gitignore and README.md #12
+37
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-platform compatibility
Makes
pnpm run build
work on both macOS and Windows platforms. While creating the reproduce repo for web-infra-dev/rspack#8170, I noticed thatpnpm run build
worked on macOS but failed on Windows.On Windows, the error messages from
pnpm run build
initially wereThose errors were fixed by adding
cross-env
. After that, thebuild:rsbuild
step still failed on Windows with the following error message (fixed with the--env-mode development
):.gitignore and README.md synchronization
Remove rspack-dist and webpack-dist from .gitignore to be in sync with README.md ("
./webpack-dist
and./rspack-dist
are purposely not added to.gitignore
.")