Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: lazy import chokidar #494

Merged
merged 1 commit into from
Nov 29, 2024
Merged

perf: lazy import chokidar #494

merged 1 commit into from
Nov 29, 2024

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Nov 29, 2024

Summary

#489

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #494 will improve performances by 66.24%

Comparing fix/chokidar (af9ed4c) with main (37bc7ee)

Summary

⚡ 1 improvements
✅ 4 untouched benchmarks

Benchmarks breakdown

Benchmark main fix/chokidar Change
⚡ examples/module-federation/mf-react-component 596.7 ms 359 ms +66.24%

@chenjiahan chenjiahan merged commit 1d279cf into main Nov 29, 2024
19 checks passed
@chenjiahan chenjiahan deleted the fix/chokidar branch November 29, 2024 06:49
@chenjiahan chenjiahan changed the title fix: lazy import chokidar perf: lazy import chokidar Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fi3ework fi3ework fi3ework approved these changes

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
change: perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@9aoy @chenjiahan @fi3ework