Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: multiple entries now do not affect each other #485

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Nov 27, 2024

Summary

Finish the test of multiple entry, resolved by #399.

#399 fixed #316.
#399 fixed #452.

Why it fixed

In #399, each entry is appended with a ?__rslib_entry__ query so importing foo from index will be distinguished as a different module from the entry module. Which will prevent foo from concatenation bailout.

FYI: layer could also distinguish the entry module, we might, could use layer if one day entry query is removed.

It's not done.

Currently, chunk splitting of shared modules is not yet supported, but at least it works for now. We will track the progress of chunk splitting in a dedicated issue.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #485 will not alter performance

Comparing multiple-entry (700c70f) with main (7c34973)

Summary

✅ 5 untouched benchmarks

@fi3ework fi3ework enabled auto-merge (squash) November 27, 2024 09:04
@fi3ework fi3ework merged commit da8191a into main Nov 27, 2024
21 checks passed
@fi3ework fi3ework deleted the multiple-entry branch November 27, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants