[swapello] fix card unable to drag issue #2173
Conversation
|
@AddisonYan Thank you for the contribution, left some minor suggestions |
AddisonYan
changed the title
AddisonYan
changed the title
|
@AddisonYan hey, I can't really reproduce the bug you mentioned on the
Could you share a video of the bug being reproduced? |
Screen.Recording.2024-07-18.at.8.59.40.PM.mov
@infomiho here is the screen recording, both list and card cannot be dragged. i am using wasp v13. are you using v14? if it is fixed in v14 then we do not need this pr anymore. |
There was a problem hiding this comment.
Left some minor comments, thank you for your effort! Sorry for taking this long to comment again.
Could I ask you to sync your fork with the Wasp repo? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork
Then I'll be able to test it with Wasp 0.14.0.
| import { Droppable as RBDDroppable } from 'react-beautiful-dnd' | ||
|
|
||
|
|
||
| export const Droppable = ({ children, ...props }) => { |
There was a problem hiding this comment.
Could you auto format this file?
It's missing a new line at the end and the indentation feels off.
| import { DragDropContext, Droppable, Draggable } from 'react-beautiful-dnd' | ||
|
|
||
| import { DragDropContext, Draggable } from 'react-beautiful-dnd' | ||
| import { Droppable } from './Drappable' |
There was a problem hiding this comment.
Could you rename the file from Drappable to Droppable?
| @@ -243,7 +243,7 @@ const List = ({ list, index, cards }) => { | |||
| index={index} | |||
| > | |||
| {(provided, snapshot) => ( | |||
| <div className='list-wrapper' | |||
| <div className={`list-wrapper`} | |||
There was a problem hiding this comment.
Could you pls revert this change since it doesn't do anything and it's not what you'd usually write for a React component static className.
Description
The current swapello's board dragging is broken, showing 'Cannot find droppable entry with id [...]'
Fix the dragging issue by creating a new droppable component
Select what type of change this PR introduces:
Update Waspc ChangeLog and version if needed
If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following:
Update example apps if needed
If you did code changes and added a new feature or modified an existing feature, make sure you satisfy the following:
waspc/examples/todoAppas needed (updated modified feature or added new feature) and manually checked it works correctly.waspc/headless-test/examples/todoAppand its e2e tests as needed (updated modified feature and its tests or added new feature and new tests for it).