WIP: added autohiding statusbar with scrollView.SetOnScrollChangeListener() #736
Conversation
bezmi
changed the title
|
Checks are failing because the method I've implemented requires API level 23 and minimum is set to 14. To fix the flickering I think it would require the action bar to be overlayed on the content. |
|
So what can we do about the API level problem? I would not like to merge this PR until travis is happy. API level 14 means Android 4.0. API Level 23 would mean Android 6.0. A quick check of the stats of the installations of wallabag in Gplay reveals that about 15% of all users are using an API level below 23. This means 85% use Android API level 23 and above anyways. From my point of view i would just increase the minimum API level. But what do the other developers think about it? //CC @wallabag/android |
|
Can anyone provide advice on how to allow the Toolbar to overlay the content so that there is no flickering when scrolling? I have tried adding EDIT: I think it is solved. I added: |
bezmi
changed the title
|
@Strubbl I believe it is now ready for review. Do you think we still need #678 after this is merged? Overview of changes:
|
added goFullscreen method to more easily toggle fullscreen on and off, made both status bar and action bar hide/show on scroll and if tapping center of screen added layout_marginTop above the paddingTop to give 2x actionbar padding from top edge so that title does not get hidden behind status bar + action bar. Added fullscreen layout flags to onCreate of the article class so that view does not shift up when full screen is toggled wrapped autohide actionbar on-scroll functionality in an if statement so it only works if API level is >= 23, otherwise it won't autohide. Implemented fullscreen on tap if the central 40% of screen is tapped. adjusted tolerance of autohide to make it feel more snappy removed unneccesary <item> tag for action bar overlay removed padding from article.xml and added padding to CSS files. added settings option for auto fullscreen fixed actionbar colour issue - was getting decorview before the activity was loaded. Removed the actionBar.hide() and show() calls, un-neccessary with the decorView stuff
bezmi
force-pushed
the
auto_hide_actionbar
branch
from
27d4fdf to
6f093e5
Compare
|
Hi @di72nn and all, it would be great to get something like this merged, providing a fullscreen reading experience without losing the ability to easily bring up the UI. Was there feedback on this PR and why it wasn't merged? I gave it a quick spin just now and it seems quite good. Or are there other ideas about what is desired for fullscreen on scroll? #114. |
|
Sorry, I still can't find the time to properly look into it. I was against approaches like that, because I think it should be implemented using layouts. But seeing that no progress in the layout department has been made, approaches like the one in this PR may be acceptable. I haven't checked the PR though. |
|
Thanks for following up. That's great, that explains the logic behind it not moving along at least. |
This addresses #114. I have tried to add the auto-hide functionality to the action bar by using scrollView.setOnScrollChangeListener(). I tried to do it with the webViewContent, but due to its nesting within the scrollview, it was really buggy.
The only issue I can see is that when the bar is showing/hiding, there is artificating at the bottom of the screen.
The system status bar doesn't get hidden, but I believe that would be relatively simple to implement.
On a side note, when playing around with the fling gestures to switch articles, I found that they were pretty unreliable. Changing them to apply on the scrollView seemed to make them much more reliable but this isn't something I've tested or fully understand...I am an android development newbie.