-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2P State Channels Milestone 2 #1224
Conversation
Just submitting officially for milestone 2 - I've added the article to be evaluated here as advised by @semuelle - Will be published on medium when we need to coordinate the announcement. |
Hey @lukastanisic99 , |
@PieWol done 😁 |
Hey @lukastanisic99 |
Sure - it's the same state of the repository as the first milestone which you evaluated (just referencing different files) - it's submitted a few days later since we were waiting for feedback on the article, but seems the feedback will be part of this evaluation 🙂 |
Hey @lukastanisic99 , |
Hey @PieWol it's the same testing guide since it's the same state of the repository (we didn't really look at it as milestone 1,milestone 2 when designing - was more for accounting purposes) but the integration tests are relevant - think I explained the reasoning in the guide |
Alright. @lukastanisic99 I have created a PR for the evaluation. There are only a few points I raised and I would appreciate it if you could improve these. Thanks. |
@PieWol I've commented on the PR and pushed changes - also rewrote the article. Please read it and let me know if you have any recommendations to improve it further. I wanted to keep it simple so everyone can understand not just engineers (hope I achieved that). |
Thanks for quickly fixing the little points I raised last week. I'm already looking forward to you establishing p2p gaming and much more with this tech on Polkadot ;) |
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#2350