-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Solang Playground milestone 3 #1199
Conversation
Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
Hi, we'll do this evaluation. |
@salaheldinsoliman thanks for the milestone delivery. Please take a look at the evaluation document in this PR and provide proper answers and fixes. The application worked well, we just have a doubt about the scope of the milestone delivery. Let me know when I can continue this evaluation. |
@ditavia-br Hello, |
@salaheldinsoliman thanks for the answer. The milestone is accepted from our side. Great job! |
Hey @salaheldinsoliman, I am doing a cursory review of the evaluation. I tried compiling the example contract using the deployed version you link in the repo README, but I'm getting |
@semuelle Hello, can you please try |
Hi @salaheldinsoliman thanks for your help, I was able to get it to run on both the deployed (unsecured) version and at Unit tests are all passing but with a few warnings. Consider fixing these for the next milestone. Other than that I was able to reproduce everything, and since @ditavia-br has accepted your delivery, I'm happy to pass this milestone. Thanks for the nice work and looking forward to seeing UI improvements on the next one. |
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1894