Add additional explanations to vocabulary creation guide #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wot-binding-templates ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Call of 27.09: Since @mjkoster needs this for the BACnet binding, he will review it as a user. |
JKRhb
force-pushed
the
expanded-guidance
branch
from
dcbe4b5
to
a3cf10d
Compare
mahdanoura
requested changes
Nov 21, 2023
JKRhb
commented
Nov 21, 2023
JKRhb
commented
Nov 30, 2023
Co-authored-by: danielpeintner <[email protected]>
Co-authored-by: danielpeintner <[email protected]>
Co-authored-by: danielpeintner <[email protected]>
Co-authored-by: Cristiano Aguzzi <[email protected]> Co-authored-by: Jan Romann <[email protected]>
|
Call of 06.12: Merging based on the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @egekorkan's work in #282, I tried to add some initial explanations on the file structure of a binding template to the
VOCABULARY-CREATION-GUIDE.mdfile. There is most certainly still a lot of room for improvement, but the document should now contain a baseline for further explanations of the creation process – let me know if you see something that should be added to this PR :)Preview | Diff