-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update F2.html #4128
base: main
Are you sure you want to change the base?
Update F2.html #4128
Conversation
- removed example 3 - updated outcome logic of checks 1 and 2 - added a third condition to check 2
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
modified the introduction to include the third check in test 2
Discussed on backlog call 11-1. Concern on call with only having heading examples, since CSS can semantically be used to convey emphasis. |
Pulled back expansion of the failure technique to include presentation markup detected by assistive technologies.
Created a new issue to track unincorporated changes #4132 |
Once the other non-structural changes have been added in the other Issue, the wording of the first check can be adjusted to something like the a prior commit |
Test: The sentence
seems superfluous and therefore a bit odd (it seems implied in the first part). But I have more general concerns about this Failure Technique. People will use it to fail content that use things like |
The existing language does not actually say what results produce a failure. I agree that the second sentence (which declares what does not fail) is restating the other side of a logic loop. If people feel its removal is unlikely to result in erroneous interpretation, I'm fine to remove. But I don't see it causes a problem being there.
As you may see from the discussion, there is general concern with the scope of this failure technique. We are removing with this change example 3 as a first attempt to reduce the problems. There is also another issue open to further this work. |
I think it could be cases where you don't want to put emphasis on a bit of text but differentiate: technical terms, taxanomic terms, etc. Or a title that is not put into quotation marks: In Edgar Allan Poe's short story A Descent into the Maelström a man recounts how he survived a shipwreck and a whirlpool. See also https://developer.mozilla.org/en-US/docs/Web/HTML/Element/i I admit there is a blurry line between |
|
But that has a precise meaning. Italics used in such a case are meant to identify the title of a book or work. The appropriate element to use would be the
That page also identifies some of these other semantic meanings some of which are also rendered as italicized text:
I do wonder, given this, if adding "visual" in the test is appropriate, as there is both a contextual and visual meaning being reinforced. Suffice it to say that we will likely be working on changes to this failure technique for awhile. At the moment, the focus is on removing the most problematic example. |
@@ -66,15 +48,14 @@ <h3>Using CSS to visually emphasize a phrase or word without conveying that emph | |||
<p>For styled text that conveys information:</p> | |||
<ol> | |||
<li>Check if there is any styled text that conveys structural information.</li> | |||
<li>Check that in addition to styling, the proper semantic structure is used with the text to convey the information.</li> | |||
<li>Check that in addition to styling, the proper semantic structure is used with the text to convey the visual information.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li>Check that in addition to styling, the proper semantic structure is used with the text to convey the visual information.</li> | |
<li>Check that in addition to styling, the proper semantic structure is used with the text to convey the information.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on discussion with Detlev and prior discussions, pulling back the addition of "visual" as that may be unnecessarily confining what kind of information is conveyed (i.e., yes, the citation element puts it in italics, but it is also conveying more than that).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
information/meaning
It seems like a citation in a paragraph that didn't use cite could be a failure if there was no indication of what the italics implies, however, I wouldn't consider not using cite it was on a references page that was marked References? |
rephrased the introduction to include mention of assistive technologyadded a third condition to check 2Resolves #4109