-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial work on language-negotiation materials #581
base: gh-pages
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for i18n-drafts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think this needs to include analysis about the potential privacy implications. In particular for minority end users. In some sense, complete customization based on the end user's preferences is rightly an ideal, but that needs to be weighed against websites being largely unvetted applications that might not have the end user's best interests in mind. |
@annevk Thanks for the comment. This material was written from the point of view of a website owner/developer, so, of course, doesn't currently include such considerations. That said, it probably should have already included some admonition about not exposing user preferences to third parties. I agree that privacy implications need to be addressed and will add some text about that shortly. Comments/suggestions welcome. |
The scope of this article seems to have some overlap with our existing article, both covering when language negotiation should be used. The existing article contains more examples. Should we probably introduce the concept of language negotiation in this article, and introduce when we should use language negotiation in our existing article? |
- Retitling the headers - Making the core flow better - Remove redundant information about why locales
- group the list by type of signal - rephrase helpfully - add a note about not inferring locale from region etc.
- fix badly indented bullet item - remove note/example formatting
This document seems to discuss both "language negotiation" and "locale negotiation". If these two terms have different meanings, it might be useful to point them out clearly so that readers will feel clearer. If not, it would be best if we could use consistent wording. |
These terms don't have different meanings. The problem is that "language negotiation" is the common term, while "locale negotiation" is more accurate. It's a good callout that I don't define the terms and pull them together early in the document. See 5950acd for fixes. |
> i. For each language range in the A-L header | ||
> a. if the language range matches an available locale's language tag, let return value be that locale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Markdown doesn't seem to support list syntax like i.
or a.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes: the article will be converted to HTML before final publication.
Sorry... long overdue and most of this is nitpicking. I'm trying to transcribe notes from about 10 days ago rather than letting it go longer; hope the result is sufficiently clear. (i) Probably the first use of "language tag" should be a link to BCP 47. Please do not link just to the registry |
I started to convert some non-prose (powerpoint) presentation materials to prose describing language negotiation. This PR is not ready to merge, as more material needs to be added and the text given a thorough edit. However, it is provided for commentary.