Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(computed): remove legacy computed warn related configurations #12179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yangxiuxiu1115
Copy link
Contributor

It looks like the recursive computed warning no longer exists in 3.5.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 15, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12179

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12179

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12179

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12179

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12179

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12179

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12179

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12179

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12179

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12179

vue

pnpm add https://pkg.pr.new/vue@12179

commit: 4267751

@edison1105
Copy link
Member

I think it's needed, see

@yangxiuxiu1115
Copy link
Contributor Author

I think it's needed, see

It doesn't look like a computed legacy computed warn here.

@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as draft October 15, 2024 08:04
@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as ready for review October 16, 2024 13:08
@edison1105 edison1105 added need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. 🧹 p1-chore Priority 1: this doesn't change code behavior. labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants