Allow RHEL8+ to configure the slapd binary when needed #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
openldap::server::config, if redhat 8-or-newer, there's asystemd::dropin_filethat makes a startup file so you can tune the user/usr/sbin/slapdruns as.The problem is, there's a subtle assumption here that your binary is actually
/usr/sbin/slapd. Ever since RHEL7.4, theopenldap-servershas been deprecated, so some of us have pivoted over to using Symas' packages, which installs everything in/opt. That is, Puppet says to use/usr/sbin/slapd"because you're on RHEL8" (wrong), instead of "because you're using a RHEL-styled package".Supersedes #429 . 429 is a better fix by dropping the systemd hack file altogether when you use a non-RH package. As we roll towards RHEL9 and everyone is having to use non-RH packages, more folks will see that, but minimally this starts unblocking the path to get there.
Closes #429