Add RUBY_VERSION feature + pin json_pure/rspec-rubocop #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we recently did a release, we don't need to pull it from git anymore.
now we can set RUBY_VERSION and the needed operator. We're very smart in naming things so the two new options are: ruby-operator and ruby-version. We need that to pin certain gems only on certain damn legacy platforms
| @@ -42,7 +44,7 @@ group <%= group %> do | |||
| gem 'beaker-rspec', :require => false | |||
| end | |||
| <% else -%> | |||
| gem '<%= gem['gem'] %>'<%= ", '#{gem['version']}'" if gem['version'] %>, <%= ' ' * (maxlen - gem['length']) %> :require => false<%= ", :git => '#{gem['git']}'" if gem['git'] %><%= ", :branch => '#{gem['branch']}'" if gem['branch'] %><%= ", :platforms => #{gem['platforms']}" if gem['platforms'] %> | |||
| gem '<%= gem['gem'] %>'<%= ", '#{gem['version']}'" if gem['version'] %>, <%= ' ' * (maxlen - gem['length']) %> :require => false<%= ", :git => '#{gem['git']}'" if gem['git'] %><%= ", :branch => '#{gem['branch']}'" if gem['branch'] %><%= ", :platforms => #{gem['platforms']}" if gem['platforms'] %><%= " if RUBY_VERSION #{gem['ruby-operator']} #{gem['ruby-version']}" if gem['ruby-operator'] && gem['ruby-version'] %> | |||
There was a problem hiding this comment.
As there's a few if's on this line, perhaps the last one's conditions could be wrapped in parens to make it stand out more from the string to the left side.
There was a problem hiding this comment.
why don't we make this a helper function or two?
There was a problem hiding this comment.
+1. but please in a different PR.
| <% 'branch' => gem['branch'], -%> | ||
| <% 'ruby-version' => gem['ruby-version'], -%> | ||
| <% 'ruby-operator' => gem['ruby-operator'], -%> | ||
| <% 'length' => gem['gem'].length + (("', '".length if gem['version']) || 0) + gem['version'].to_s.length -%> |
There was a problem hiding this comment.
what's going on here?
(also, monads would be pretty sweet now…)
There was a problem hiding this comment.
we make dark black magic to determine the indentation in the Gemfile.
There was a problem hiding this comment.
that's what i'm saying we should have a function for
There was a problem hiding this comment.
I created #201 for this
bastelfreak
force-pushed
the
testplatform
branch
from
cc87a06 to
c3d7db4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will implement #198